HDDS-13932. Add test cases for PUT bucket ACL #9371

Russole · 2025-11-25T22:53:59Z

What changes were proposed in this pull request?

This PR improves and expands the test coverage of the PUT Bucket ACL operation in BucketEndpoint, ensuring correct handling of S3 ACL semantics under different request formats.

Added VALID_ACL_XML constant to provide a reusable, well-formed S3 ACL body for tests.
Added new test cases to fully validate the behavior of PUT /{bucket}?acl:
Missing ACL headers with a valid XML body should succeed.
Missing ACL headers and missing body should fail with a WebApplicationException caused by an OS3Exception with InvalidRequest.
PUT ACL on a non-existing bucket should throw an OS3Exception with NoSuchBucket.
Header-based ACL update using x-amz-grant-full-control should succeed.
Invalid XML body (non-XML input) should trigger an OS3Exception with InvalidRequest.
Malformed ACL grant header (e.g., missing "=") should produce an OS3Exception with InvalidArgument.
Removed two ineffective test cases (testBucketFailWithAuthHeaderMissing and testBucketFailWithInvalidHeader) because they used a try/catch without assertThrows, causing them to pass even when no exception was thrown.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13932

How was this patch tested?

This patch includes new and enhanced unit tests in TestBucketPut to verify the updated behavior.
All tests were executed locally and passed.
Additionally, all CI pipelines passed after the patch was pushed.

…est cases

Gargi-jais11

Thanks @Russole for the patch.
Left some comments below.

Gargi-jais11 · 2025-11-26T09:29:14Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+
+    assertEquals("InvalidRequest", os3.getCode());
+    assertEquals(400, os3.getHttpCode());


Here also we should use constant references consistently.

Suggested change

assertEquals("InvalidRequest", os3.getCode());

assertEquals(400, os3.getHttpCode());

assertEquals(INVALID_REQUEST.getCode(), os3.getCode());;

assertEquals(400, os3.getHttpCode());

Thanks for the suggestion. I've updated the code to use constant references consistently.

Gargi-jais11 · 2025-11-26T09:35:21Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

-      assertEquals(HTTP_NOT_FOUND, ex.getHttpCode());
-      assertEquals(MALFORMED_HEADER.getCode(), ex.getCode());
-    }
+  public void testAclWithMissingHeadersAndNoBody() throws Exception {


We can also have a test scenario where both headers and body are present, and check headers take precedence and the body is ignored.
Verify that the permissions set on the bucket is as per header and not according to the body.
testPutAclWithBothHeadersAndBody()

Mock header with one permission

Provide body with different permission (should be ignored)

Verify that READ permission was set (from header), not FULL_CONTROL (from body)

Thanks for the suggestion, I have added a new test to cover this scenario:
In this test:

The header grants READ via x-amz-grant-read (id=owner-id),

The XML body (VALID_ACL_XML) grants FULL_CONTROL,

The call succeeds with HTTP 200, and We verify that an ACL entry for owner-id with ACCESS scope is present on the bucket, which is derived from the header.

Since putAcl() only takes the header-based path when any grant header is present (and skips the body in that case), this test documents that the header takes precedence over the body when both are provided.

This test case ...MissingHeadersAndNoBody is no longer necessary.

Gargi-jais11 · 2025-11-26T09:46:03Z

Few other scenarios are also possible, so do you have idea what will be the behaviour in the below scenarios?:

What if header exists but is empty and no body is there?

example:
when(mockHeaders.getHeaderString(S3Acl.GRANT_FULL_CONTROL))
      .thenReturn(""); //empty
Response resp = bucketEndpoint.put(bucketName, "acl", null);

Or what if header exists but has white space only and no body?

example:
when(mockHeaders.getHeaderString(S3Acl.GRANT_FULL_CONTROL))
      .thenReturn("  "); // whitespace
Response resp = bucketEndpoint.put(bucketName, "acl", null);

So in the above two case what should happen, create bucket should pass or fail ? And according do testing of these two scenarios as well.

…rantHeaderValue in TestBucketPut

Russole · 2025-11-28T13:08:41Z

Few other scenarios are also possible, so do you have idea what will be the behaviour in the below scenarios?:

What if header exists but is empty and no body is there?
example:
when(mockHeaders.getHeaderString(S3Acl.GRANT_FULL_CONTROL))
      .thenReturn(""); //empty
Response resp = bucketEndpoint.put(bucketName, "acl", null);
Or what if header exists but has white space only and no body?
example:
when(mockHeaders.getHeaderString(S3Acl.GRANT_FULL_CONTROL))
      .thenReturn("  "); // whitespace
Response resp = bucketEndpoint.put(bucketName, "acl", null);
So in the above two case what should happen, create bucket should pass or fail ? And according do testing of these two scenarios as well.

Thanks for pointing out these additional edge cases.

I checked the current implementation of BucketEndpoint.putAcl() (in particular getAndConvertAclOnBucket / getAndConvertAclOnVolume) and added tests to document the behavior for both scenarios:

Header exists but is empty (""), no body

when(mockHeaders.getHeaderString(S3Acl.GRANT_FULL_CONTROL))
    .thenReturn("");
Response resp = bucketEndpoint.put(bucketName, "acl", null);

In this case, StringUtils.isEmpty(value) returns true, so the helper returns an empty ACL list without throwing. The PUT ?acl call succeeds with HTTP 200 and effectively behaves as “no grants provided”.
This is covered by:

@Test
public void testPutAclWithEmptyGrantHeaderValue() throws Exception {
  assertEquals(200, resp.getStatus());
}

Header exists but has only whitespace (" "), no body

when(mockHeaders.getHeaderString(S3Acl.GRANT_FULL_CONTROL))
    .thenReturn("  ");
Response resp = bucketEndpoint.put(bucketName, "acl", null);

Here StringUtils.isEmpty(value) is false, so we attempt to parse the value.
Splitting on "=" produces a single part (part.length != 2), which triggers:

throw newError(S3ErrorTable.INVALID_ARGUMENT, acl);

So this scenario fails with OS3Exception(INVALID_ARGUMENT, 400).
This is covered by:

@Test
public void testPutAclWithWhitespaceGrantHeaderValue() throws Exception {
  OS3Exception ex = assertThrows(OS3Exception.class,
      () -> bucketEndpoint.put(bucketName, "acl", null));
  assertEquals(INVALID_ARGUMENT.getCode(), ex.getCode());
  assertEquals(400, ex.getHttpCode());
}

These two tests make the current behavior explicit and should help prevent regressions around header parsing for PUT ?acl.

Gargi-jais11

Thanks @Russole for updating the patch.
Just one minor comment. Overall LGTM.

Gargi-jais11 · 2025-12-01T04:48:17Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+         .orElseThrow(() -> new AssertionError("owner-id ACL not found"));
+
+    assertEquals("owner-id", ownerAcl.getName());


Can you please also add an assert statement to verify the permission is READ (from header), not FULL_CONTROL (from body).

Added the requested assertions — the test now verifies that READ from the header is applied and FULL_CONTROL from the body is ignored.

Gargi-jais11 · 2025-12-02T04:58:29Z

@Russole there is no need to close the PR everytime you make changes. If you wish you can mark it as draft and after its done make it ready for review.

Gargi-jais11

Patch LGTM!

Russole · 2025-12-02T13:15:08Z

Thank you for the clarification.
I’ll keep the PR open and use the Draft status while making updates moving forward.
Appreciate your guidance.

Russole · 2025-12-05T14:28:51Z

Just checking in kindly. Since the patch already has LGTM,
please feel free to let me know if any adjustments are needed —
I’m very happy to update it anytime. Thank you!

chungen0126

Thanks @Russole for the improvement. Left some comments.

chungen0126 · 2025-12-08T09:09:43Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+
+    InputStream body = new ByteArrayInputStream(VALID_ACL_XML.getBytes(StandardCharsets.UTF_8));
+
+    Response resp = bucketEndpoint.put(bucketName, "acl", body);


Introduce a static string constant to replace all hardcoded instances of 'acl'.

chungen0126 · 2025-12-08T09:12:11Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+    InputStream body = new ByteArrayInputStream(VALID_ACL_XML.getBytes(StandardCharsets.UTF_8));
+
+    Response resp = bucketEndpoint.put(bucketName, "acl", body);
+    assertEquals(200, resp.getStatus());


Suggested change

assertEquals(200, resp.getStatus());

assertEquals(HTTP_OK, resp.getStatus());

Use HTTP_OK to replace 200.

chungen0126 · 2025-12-08T09:12:20Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+
+    Response resp = bucketEndpoint.put(bucketName, "acl", null);
+
+    assertEquals(200, resp.getStatus());


Suggested change

assertEquals(200, resp.getStatus());

assertEquals(HTTP_OK, resp.getStatus());

Use HTTP_OK to replace 200.

chungen0126 · 2025-12-08T09:12:27Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+        VALID_ACL_XML.getBytes(StandardCharsets.UTF_8));
+
+    Response resp = bucketEndpoint.put(bucketName, "acl", body);
+    assertEquals(200, resp.getStatus());


Suggested change

assertEquals(200, resp.getStatus());

assertEquals(HTTP_OK, resp.getStatus());

Use HTTP_OK to replace 200.

chungen0126 · 2025-12-08T09:12:34Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+
+    Response resp = bucketEndpoint.put(bucketName, "acl", null);
+
+    Assertions.assertEquals(200, resp.getStatus());


Suggested change

Assertions.assertEquals(200, resp.getStatus());

assertEquals(HTTP_OK, resp.getStatus());

Use HTTP_OK to replace 200.

chungen0126 · 2025-12-08T09:13:54Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+    OS3Exception os3 = (OS3Exception) cause;
+
+    assertEquals(INVALID_REQUEST.getCode(), os3.getCode());
+    assertEquals(400, os3.getHttpCode());


Suggested change

assertEquals(400, os3.getHttpCode());

assertEquals(HTTP_BAD_REQUEST, os3.getHttpCode());

Use HTTP_BAD_REQUEST to replace 400.

chungen0126 · 2025-12-08T09:14:01Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+    OS3Exception os3 = (OS3Exception) cause;
+
+    assertEquals(INVALID_REQUEST.getCode(), os3.getCode());
+    assertEquals(400, os3.getHttpCode());


Suggested change

assertEquals(400, os3.getHttpCode());

assertEquals(HTTP_BAD_REQUEST, os3.getHttpCode());

Use HTTP_BAD_REQUEST to replace 400.

chungen0126 · 2025-12-08T09:14:06Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+        () -> bucketEndpoint.put(bucketName, "acl", null));
+
+    assertEquals(INVALID_ARGUMENT.getCode(), ex.getCode());
+    assertEquals(400, ex.getHttpCode());


Suggested change

assertEquals(400, ex.getHttpCode());

assertEquals(HTTP_BAD_REQUEST, os3.getHttpCode());

Use HTTP_BAD_REQUEST to replace 400.

chungen0126 · 2025-12-08T09:14:13Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+        () -> bucketEndpoint.put(bucketName, "acl", null));
+
+    Assertions.assertEquals(INVALID_ARGUMENT.getCode(), ex.getCode());
+    Assertions.assertEquals(400, ex.getHttpCode());


Suggested change

Assertions.assertEquals(400, ex.getHttpCode());

assertEquals(HTTP_BAD_REQUEST, os3.getHttpCode());

Use HTTP_BAD_REQUEST to replace 400.

chungen0126 · 2025-12-08T09:17:42Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

-      assertEquals(MALFORMED_HEADER.getCode(), ex.getCode());
-    }
+  public void testAclWithMissingHeaders() throws Exception {
+    bucketEndpoint.getClient().getObjectStore().createS3Bucket(bucketName);


Why do we need to create an S3 bucket before bucket put?

Because putAcl() first calls getS3Bucket(bucketName).
If the bucket does not exist, it throws NO_SUCH_BUCKET and never reaches any ACL parsing logic.
To test the ACL behavior, the bucket must already exist.

echonesis

Thanks @Russole , left some comments.

echonesis · 2025-12-08T09:46:14Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+    OS3Exception ex = assertThrows(OS3Exception.class,
+        () -> bucketEndpoint.put(bucketName, "acl", null));
+
+    Assertions.assertEquals(INVALID_ARGUMENT.getCode(), ex.getCode());


Suggested change

Assertions.assertEquals(INVALID_ARGUMENT.getCode(), ex.getCode());

assertEquals(INVALID_ARGUMENT.getCode(), ex.getCode());

assertEquals is enough.

echonesis · 2025-12-08T09:52:24Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+    bucketEndpoint.getClient().getObjectStore().createS3Bucket(bucketName);
+
+    when(mockHeaders.getHeaderString(S3Acl.GRANT_FULL_CONTROL))
+        .thenReturn("  "); // whitespace only


Consider introducing a static constant for the whitespace string to improve readability:

Suggested change

.thenReturn(" "); // whitespace only

private static final String WHITESPACE_ONLY = " ";

when(mockHeaders.getHeaderString(S3Acl.GRANT_FULL_CONTROL))

.thenReturn(WHITESPACE_ONLY);

Russole · 2025-12-08T13:05:59Z

Thanks @echonesis and @chungen0126 for the review and helpful comments — really appreciate your guidance! 🙏
I’ll update the tests accordingly.

echonesis · 2025-12-09T10:06:19Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+          "    </Grant>" +
+          "  </AccessControlList>" +
+          "</AccessControlPolicy>";
+  private static final String ACL = "acl";


Perhaps you could use OzoneConsts.ACL.

Thanks for the suggestion!
I've removed the local "acl" constant and updated the tests to use OzoneConsts.ACL so that we rely on the shared Ozone constant instead of redefining it.

Russole · 2025-12-09T18:31:11Z

Thanks to @Gargi-jais11, @chungen0126, and @echonesis for the review and helpful feedback.

echonesis · 2025-12-15T02:39:39Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+        () -> bucketEndpoint.put(bucketName, OzoneConsts.ACL, null));
+
+    assertEquals(INVALID_ARGUMENT.getCode(), ex.getCode());
+    assertEquals(400, ex.getHttpCode());


Suggested change

assertEquals(400, ex.getHttpCode());

assertEquals(HTTP_BAD_REQUEST, ex.getHttpCode());

Use HTTP_BAD_REQUEST to replace 400.

echonesis

Thanks @Russole for updating the patch. LGTM!

Gargi-jais11 · 2026-01-05T05:48:50Z

@ivandika3 and @peterxcli Please take a look on the patch.

Russole · 2026-01-10T03:52:49Z

Thanks @Gargi-jais11 for the earlier ping.
Just following up to see if anyone could help review this PR.
@chungen0126 , would you have time to take a look when convenient?
Thanks!

chungen0126

+1 LGTM

adoroszlai

Thanks @Russole for the patch and sorry for the conflicts. Can you please move the test cases to TestBucketAcl or TestBucketAclHandler? BucketEndpoint.putAcl no longer exists (code refactored into BucketAclHandler). TestBucketAcl adds the ?acl query param, so you can use BucketEndpoint.put there. Please check if existing test cases cover any of the new ones.

adoroszlai · 2026-01-15T15:04:58Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+    Response resp = bucketEndpoint.putAcl(bucketName, body);
+    assertEquals(HTTP_OK, resp.getStatus());


Now we have helper method to simplify this.

assertSucceeds(() -> bucketEndpoint.put(bucketName, body));

adoroszlai · 2026-01-15T15:09:08Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

-      assertEquals(HTTP_NOT_FOUND, ex.getHttpCode());
-      assertEquals(MALFORMED_HEADER.getCode(), ex.getCode());
-    }
+  public void testAclWithMissingHeadersAndNoBody() throws Exception {


This test case ...MissingHeadersAndNoBody is no longer necessary.

adoroszlai · 2026-01-15T15:12:03Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java

+    OS3Exception ex = assertThrows(OS3Exception.class,
+        () -> bucketEndpoint.putAcl(bucketName, null));
+
+    assertEquals(INVALID_ARGUMENT.getCode(), ex.getCode());
+    assertEquals(HTTP_BAD_REQUEST, ex.getHttpCode());


Now we have helper to simplify this:

assertErrorResponse(INVALID_ARGUMENT, () -> bucketEndpoint.put(bucketName, null));

Russole added 4 commits November 24, 2025 22:09

HDDS-13932. Fix TestBucketPut by correcting test logic and updating t…

2d24393

…est cases

Clean TestBucketPut Setup() Part

1d5e9a1

Fix Unused Import

ce0facd

Ensure consistent usage of assertEquals() in TestBucketPut tests

230f88e

Gargi-jais11 suggested changes Nov 26, 2025

View reviewed changes

Gargi-jais11 reviewed Nov 26, 2025

View reviewed changes

Russole added 4 commits November 27, 2025 22:40

Use INVALID_REQUEST.getCode() instead of inline string InvalidRequest

41b7a91

Add testPutAclWithBothHeadersAndBody in TestBucketPut

543f78a

Add testPutAclWithEmptyGrantHeaderValue and testPutAclWithWhitespaceG…

a20de05

…rantHeaderValue in TestBucketPut

Fix CheckStyle

e0b3ca9

Russole closed this Nov 27, 2025

Russole deleted the HDDS-13932 branch November 27, 2025 23:15

Fix DeadStore

e899b94

Russole reopened this Nov 28, 2025

Russole requested a review from Gargi-jais11 November 28, 2025 16:59

Gargi-jais11 suggested changes Dec 1, 2025

View reviewed changes

Improve PUT ACL test coverage for header handling and precedence

bc3552b

Russole closed this Dec 1, 2025

Russole restored the HDDS-13932 branch December 1, 2025 22:13

Russole reopened this Dec 1, 2025

Russole requested a review from Gargi-jais11 December 1, 2025 22:14

Gargi-jais11 approved these changes Dec 2, 2025

View reviewed changes

adoroszlai requested review from ivandika3 and peterxcli December 5, 2025 14:34

chungen0126 changed the title ~~HDDS 13932. Fix TestBucketPut by correcting test logic and updating test cases~~ HDDS-13932. Fix TestBucketPut by correcting test logic and updating test cases Dec 8, 2025

chungen0126 requested changes Dec 8, 2025

View reviewed changes

echonesis reviewed Dec 8, 2025

View reviewed changes

Merge branch 'master' into HDDS-13932

32735b5

Refine implementation based on review comments

5257527

Russole requested review from chungen0126 and echonesis December 8, 2025 13:31

Replace literal 400 with HTTP_BAD_REQUEST

58075a2

echonesis reviewed Dec 9, 2025

View reviewed changes

Replace literal acl with OzoneConsts.ACL in TestBucketPut

3de3aac

Russole requested a review from echonesis December 10, 2025 11:20

echonesis reviewed Dec 15, 2025

View reviewed changes

Replace 400 with HTTP_BAD_REQUEST

c426daa

Russole requested a review from echonesis December 15, 2025 14:42

echonesis approved these changes Dec 18, 2025

View reviewed changes

Russole added 3 commits December 24, 2025 06:10

Merge branch 'master' into HDDS-13932

99dc3d8

Update Put ACL tests to align with refactored endpoint

8992171

Fix CheckStyle

331719d

chungen0126 approved these changes Jan 11, 2026

View reviewed changes

adoroszlai reviewed Jan 15, 2026

View reviewed changes

adoroszlai marked this pull request as draft January 15, 2026 15:16

adoroszlai changed the title ~~HDDS-13932. Fix TestBucketPut by correcting test logic and updating test cases~~ HDDS-13932. Add test cases for PUT bucket ACL Jan 15, 2026

adoroszlai added test s3 S3 Gateway labels Jan 15, 2026

Merge branch 'apache:master' into HDDS-13932

ee29e8d


		assertEquals("InvalidRequest", os3.getCode());
		assertEquals(400, os3.getHttpCode());

		.orElseThrow(() -> new AssertionError("owner-id ACL not found"));

		assertEquals("owner-id", ownerAcl.getName());


		InputStream body = new ByteArrayInputStream(VALID_ACL_XML.getBytes(StandardCharsets.UTF_8));

		Response resp = bucketEndpoint.put(bucketName, "acl", body);

	assertEquals(200, resp.getStatus());
	assertEquals(HTTP_OK, resp.getStatus());


		Response resp = bucketEndpoint.put(bucketName, "acl", null);

		Assertions.assertEquals(200, resp.getStatus());

	assertEquals(400, os3.getHttpCode());
	assertEquals(HTTP_BAD_REQUEST, os3.getHttpCode());

	assertEquals(400, ex.getHttpCode());
	assertEquals(HTTP_BAD_REQUEST, os3.getHttpCode());

	Assertions.assertEquals(400, ex.getHttpCode());
	assertEquals(HTTP_BAD_REQUEST, os3.getHttpCode());

	Assertions.assertEquals(INVALID_ARGUMENT.getCode(), ex.getCode());
	assertEquals(INVALID_ARGUMENT.getCode(), ex.getCode());

	assertEquals(400, ex.getHttpCode());
	assertEquals(HTTP_BAD_REQUEST, ex.getHttpCode());

		Response resp = bucketEndpoint.putAcl(bucketName, body);
		assertEquals(HTTP_OK, resp.getStatus());

HDDS-13932. Add test cases for PUT bucket ACL #9371

Are you sure you want to change the base?

HDDS-13932. Add test cases for PUT bucket ACL #9371

Conversation

Russole commented Nov 25, 2025

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

Uh oh!

Gargi-jais11 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gargi-jais11 commented Nov 26, 2025

Uh oh!

Russole commented Nov 28, 2025

Uh oh!

Gargi-jais11 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gargi-jais11 commented Dec 2, 2025

Uh oh!

Gargi-jais11 left a comment

Choose a reason for hiding this comment

Uh oh!

Russole commented Dec 2, 2025

Uh oh!

Russole commented Dec 5, 2025

Uh oh!

chungen0126 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

echonesis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Russole commented Dec 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

echonesis left a comment •

edited

Loading